New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider being generic over http client #24

Open

busyboredom opened this issue Feb 2, 2023 · 0 comments

Labels

Owner

busyboredom commented Feb 2, 2023

If acceptxmr were generic over http client, consumers could bring their own and further customize how the connect to their daemon.

This would also enable elegant unit testing of the RPC and authentication modules.

It would make the API messier though, and potentially adds significant complexity and maintenance overhead to the RPC module as well.

busyboredom added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment