Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails #24

Closed
Arcanemagus opened this issue Oct 21, 2015 · 11 comments
Closed

Installation fails #24

Arcanemagus opened this issue Oct 21, 2015 · 11 comments
Labels

Comments

@Arcanemagus
Copy link

This package is failing to install for me on:
Atom 1.0.19
Windows 8.1 x64

Installing “[email protected]” failed.

> [email protected] install C:\Users\Landon\AppData\Local\Temp\apm-install-dir-115921-231128-1opv8ga\node_modules\language-markdown\node_modules\pathwatcher\node_modules\runas
> node-gyp rebuild


C:\Users\Landon\AppData\Local\Temp\apm-install-dir-115921-231128-1opv8ga\node_modules\language-markdown\node_modules\pathwatcher\node_modules\runas>if not defined npm_config_node_gyp (node "C:\Users\Landon\AppData\Local\atom\app-1.0.19\resources\app\apm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild ) 
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0".

gypnpm ERR! Windows_NT 6.2.9200
npm ERR! argv "C:\\Users\\Landon\\AppData\\Local\\atom\\app-1.0.19\\resources\\app\\apm\\bin\\node.exe" "C:\\Users\\Landon\\AppData\\Local\\atom\\app-1.0.19\\resources\\app\\apm\\node_modules\\npm\\bin\\npm-cli.js" "--globalconfig" "C:\\Users\\Landon\\.atom\\.apm\\.apmrc" "--userconfig" "C:\\Users\\Landon\\.atom\\.apmrc" "install" "C:\\Users\\Landon\\AppData\\Local\\Temp\\d-115921-231128-m1k57s\\package.tgz" "--target=0.30.7" "--arch=ia32"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

From a bit of searching it almost looks like I would need to install VS2013 (or higher)? chjj/pty.js#60

As this hasn't been required for any other Atom package that seems a bit odd...
If you need any more information please let me know.

@burodepeper
Copy link
Owner

That is weird. I will look into this tomorrow.

@burodepeper
Copy link
Owner

@Arcanemagus I've checked and updated the dependencies (in v0.1.1) (I saw we used an older version of pathwatcher) so perhaps this might do the trick. Could you un- and re-install the package to see if this solves this?

@burodepeper
Copy link
Owner

@Arcanemagus Another user on Windows had the same issue, and it appeared to be because of a wrong version of Python. I have no idea where that comes into play. Anyway, try running npm install runas from the language-markdown directory, or perhaps install it globally. If things go according to plan, it will fail building runas and show some more specific output. After that I'm afraid I can't help you any further than by directing you to their repository. Let me know how things play out.

This was the output from the other user: http://pastebin.com/bEs450PD

@Arcanemagus
Copy link
Author

Yep, definitely looks like an issue with the runas repository. Although I'm not seeing the python issue (I have 2.7.10 installed).

I've filed atom-archive/node-runas#19 over there. Marking this as closed since it's not an issue with this package 😉.

@burodepeper
Copy link
Owner

Thanks for reporting the issue anyway!

@Arcanemagus
Copy link
Author

So it might be quite simple to work around this in this package. You are requiring node-pathwatcher, which is what is requiring node-runas, which is what is causing all these issues.

From what I could see looking over the code, the only place you are utilizing this is here to synchronously get a listing of files. Is there a reason you are using this package instead of a simpler method?

@burodepeper
Copy link
Owner

I found the Directory class as part of the Atom API so I thought it would be safe to use. Apparently not, or I'm requiring the 'wrong' pathwatcher. But as you suggest, there might be a simpler way of getting the list of files, probably via fs. I'll have a look at that. Thanks for your help!

@burodepeper
Copy link
Owner

Hey @Arcanemagus, I've just published a v0.1.2 version that doesn't depend on pathwatcher directly, but requires Directory as provided by Atom. I assume this should work better. Would you mind giving the update a try?

@Arcanemagus
Copy link
Author

Sure, I'll try it when I get into work tomorrow, thanks!

@Arcanemagus
Copy link
Author

Sorry it took so long to get back to you, v0.1.2 installed with no issues.

@burodepeper
Copy link
Owner

Not a problem, and thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants