Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for correct alpha and color values #507

Merged
merged 4 commits into from
Jan 29, 2023

Conversation

wasky
Copy link
Contributor

@wasky wasky commented Jan 19, 2023

This won't work until #505 is accepted.

@wasky
Copy link
Contributor Author

wasky commented Jan 19, 2023

@burhanrashid52 There's something wrong with CI build for this PR. It's running for over and hour now. Can you cancel the build manually?

@burhanrashid52
Copy link
Owner

@burhanrashid52 There's something wrong with CI build for this PR. It's running for over and hour now. Can you cancel the build manually?

I am also not sure. Can you push something to re-run this ?

@wasky
Copy link
Contributor Author

wasky commented Jan 20, 2023

Everything's OK now, PR ready for review.

I split this PR into 4 commits for easier review. I suggest to review every commit separately.

@burhanrashid52
Copy link
Owner

@wasky Since we have moved some test in androidTest, I am not sure if those test will run in the CI because the gradle test only run unit tests.
Need to make changes in CI to run the test under androidTest as well.

@burhanrashid52
Copy link
Owner

@wasky Since we have moved some test in androidTest, I am not sure if those test will run in the CI because the gradle test only run unit tests. Need to make changes in CI to run the test under androidTest as well.

Does ./gradlew check --stacktrace run all the test in photoEditor ? Can you confirm?

@wasky
Copy link
Contributor Author

wasky commented Jan 29, 2023

./gradlew test runs tests in test folder. ./gradlew connectedCheck runs tests in androidTest folder. Both tasks are executed by Github Actions. As a confirmation I created a new branch from this pull request in my forked repo and changed tests to fail. You can find the branch here and the results from tests here.

@burhanrashid52 burhanrashid52 merged commit 825fab9 into burhanrashid52:master Jan 29, 2023
@wasky wasky deleted the PE-496 branch January 29, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants