-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to make only one sticker / text / emoji / added view selectable at a time. #219
Comments
Yes, you are right. This is not the intended behaviour. There should be one selected at a time.
|
For this, I'm assuming you mean the
^^^ For this, I'll just show you in the PR. I almost have it done.
This is correct. If you click on an empty area, in a selected view, click through will not work and the current selected view will remain selected. I believe this to be ideal behavior, both from user testing and how PhotoEditorSDK works. |
Sounds great!!. Let me know when you are done. I'll review the PR |
The current editor behavior can have multiple stickers / views / text selected at a time (see screenshot). This is a consequence of having the
MultiTouchListener
instances not know about each other (oneMultiTouchListener
is attached to each sticker / view / text).I have a fix for this, but I'm not sure if this is intended behavior. My guess is it's not, since a user won't be clicking and moving multiple stickers at the same time. Additionally, this is not the behavior in
PhotoEditorSDK
that this project is inspired by.This also has other consequences, as a lot of my use cases require knowing the "currently selected" sticker / view / text. Specifically, for #214, I want to make the "currently selected" sticker / view / text not transparent click through, as it's really annoying to the user to click inside the
HelperBox
and have the sticker / view / text deselected.TL;DR:
Screenshot illustrating current behavior:
The text was updated successfully, but these errors were encountered: