Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master !== main, no results saved #280

Open
yaroslav-ilin opened this issue Aug 9, 2020 · 1 comment
Open

master !== main, no results saved #280

yaroslav-ilin opened this issue Aug 9, 2020 · 1 comment

Comments

@yaroslav-ilin
Copy link

In preparation for the upcoming Github feature described in github/roadmap#63 I renamed the base branch of my new repo to main instead of the default master.

Bundlewatch reported the following failure on that repo.

$ bundlewatch

[INFO] Retrieving comparison

[ERROR] Unable to fetch fileDetails for baseBranch=master from https://service.bundlewatch.io/store code=Request failed with status code 404

[INFO] master !== main, no results saved

[INFO] Saving results

The error can also be seen live on CI: https://travis-ci.com/github/nilfalse/ctf/jobs/370145494

Steps to reproduce

  1. Setup Github repo to have main as a default branch instead of master.
  2. Delete master branch.

What is the expected behavior?

Bundlewatch should be able to compare size to any default branch in the Github repo even if it's not called master.

@markojak
Copy link

I am experiencing this problem as well - This seems to be happening because of the renaming of master to main which all new repos will have by default.

Is there an expected resolution on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants