Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --validate option for buildtest build #1729

Merged
merged 5 commits into from
Mar 16, 2024
Merged

add --validate option for buildtest build #1729

merged 5 commits into from
Mar 16, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

@Xiangs18 Xiangs18 linked an issue Mar 15, 2024 that may be closed by this pull request
7 tasks
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 34.24%. Comparing base (2d1d74a) to head (75b94ac).
Report is 10 commits behind head on devel.

Files Patch % Lines
buildtest/cli/build.py 60.00% 2 Missing ⚠️
buildtest/cli/show.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #1729       +/-   ##
===========================================
- Coverage   80.81%   34.24%   -46.58%     
===========================================
  Files          57       57               
  Lines        6432     6341       -91     
===========================================
- Hits         5198     2171     -3027     
- Misses       1234     4170     +2936     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiangs18
Copy link
Collaborator Author

Xiangs18 commented Mar 15, 2024

You probably need to update this link: https://www.alcf.anl.gov/support-center/theta to pass urls check. Now is 404

Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @Xiangs18 i took a look and this looks acceptable to merge. I dont think i have any issues yet. Let me check codecov to see if testing looks fine.

@shahzebsiddiqui
Copy link
Member

You probably need to update this link: https://www.alcf.anl.gov/support-center/theta to pass urls check. Now is 404

Let's go ahead and remove the link.

@shahzebsiddiqui shahzebsiddiqui changed the title add --validate option add --validate option for buildtest build Mar 15, 2024
@Xiangs18 Xiangs18 merged commit 822dc29 into devel Mar 16, 2024
36 of 38 checks passed
@Xiangs18 Xiangs18 deleted the dev_validate branch March 16, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: add option for validating buildspecs when running 'buildtest build'
2 participants