Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove short option "-t" for "--theme" #1576

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Remove short option "-t" for "--theme" #1576

merged 3 commits into from
Aug 2, 2023

Conversation

braeeast2001
Copy link
Collaborator

@braeeast2001 braeeast2001 commented Jul 25, 2023 •
edited
Loading

To complete this issue the following will be done:

  • Update bash completion script and remove -t option wherever its used for --theme
  • Remove -t from documentation wherever its mentioned for --theme also check all .. command-output where its -t and replace with --theme
  • Update any docstring or comment throughout the code base

@braeeast2001 braeeast2001 self-assigned this Jul 25, 2023
@braeeast2001 braeeast2001 linked an issue Jul 25, 2023 that may be closed by this pull request
Remove short option -t for --theme #1571
Closed
3 tasks
@braeeast2001
Update bash_completion.sh
5310507 
Removed "-t" where used in conjunction with "--theme"
@braeeast2001
Copy link
Collaborator Author

braeeast2001 commented Jul 25, 2023 •
edited
Loading

Bash Script - Line 303
@shahzebsiddiqui

Should I remove the '-t' at the end of this line?

@braeeast2001 braeeast2001 changed the title Remove short option "-t" for "-theme" Remove short option "-t" for "--theme" Jul 31, 2023
@braeeast2001
Update command_line_tutorial.rst
aab3264 
Replace all -t for theme with --theme
@shahzebsiddiqui
Copy link
Member

@braeeast2001 can you confirm this task is complete. Is -t replaced to --theme

@braeeast2001
Copy link
Collaborator Author

@braeeast2001 can you confirm this task is complete. Is -t replaced to --theme

This task is complete.

shahzebsiddiqui
shahzebsiddiqui approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahzebsiddiqui shahzebsiddiqui merged commit 931208b into devel Aug 2, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the 1571_remove_-t branch August 2, 2023 14:19
@shahzebsiddiqui shahzebsiddiqui mentioned this pull request Aug 3, 2023
Merged
@shahzebsiddiqui shahzebsiddiqui mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui approved these changes

Assignees

@braeeast2001 braeeast2001

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove short option -t for --theme
2 participants
@braeeast2001 @shahzebsiddiqui