Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symlink test failing on readthedocs container. #1411

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix symlink test failing on readthedocs container. #1411

merged 1 commit into from
Mar 3, 2023

Conversation

prathmesh4321
Copy link
Collaborator

@prathmesh4321 prathmesh4321 commented Mar 3, 2023 •
edited
Loading

@shahzebsiddiqui . Please review the PR.

Screen Shot 2023-03-03 at 11 41 08 AM

Screen Shot 2023-03-03 at 10 32 02 AM

@prathmesh4321 prathmesh4321 linked an issue Mar 3, 2023 that may be closed by this pull request
[DOCS]: testing failing for symbolic link #1403
Closed
2 tasks
shahzebsiddiqui
shahzebsiddiqui approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job this looks good. I see the test is PASSING

@shahzebsiddiqui shahzebsiddiqui merged commit e162a4c into devel Mar 3, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the fix_symlink_test branch March 3, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS]: testing failing for symbolic link
2 participants
@prathmesh4321 @shahzebsiddiqui