Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA workflow to test pack master against lifecycle master #568

Closed
natalieparellano opened this issue Apr 7, 2020 · 4 comments
Closed

GHA workflow to test pack master against lifecycle master #568

natalieparellano opened this issue Apr 7, 2020 · 4 comments
Labels
status/blocked Issue or PR that is blocked. See comments. status/discussion-needed Issue or PR that requires in-depth discussion. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

Description

Once #565 is complete, we won't have any automated tests of pack master against lifecycle master.

Proposed solution

We should test master to master, but not against PRs. This configuration should only run on pushes to pack master.
@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Apr 7, 2020
@natalieparellano
Copy link
Member Author

Rationale for why we don't want master to master on PRs is outlined here: #524 (comment)

@natalieparellano natalieparellano added status/blocked Issue or PR that is blocked. See comments. and removed status/triage Issue or PR that requires contributor attention. labels Apr 7, 2020
@natalieparellano
Copy link
Member Author

Consider: whether this should be in pack or lifecycle.

@dfreilich dfreilich added the status/discussion-needed Issue or PR that requires in-depth discussion. label May 27, 2020
@jromero
Copy link
Member

jromero commented Feb 17, 2021

The risk is minimal and lifecycle maintainers already run acceptance test on pack using a prerelease version of lifecycle.

@jromero jromero closed this as completed Feb 17, 2021
@dfreilich
Copy link
Member

Automating this on lifecycle's end is blocked on #904, which is prioritized in this milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/blocked Issue or PR that is blocked. See comments. status/discussion-needed Issue or PR that requires in-depth discussion. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jromero @natalieparellano @dfreilich