Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameter naming for target architecture #2175

Open
nicolasbender opened this issue Jun 3, 2024 · 2 comments
Open

Inconsistent parameter naming for target architecture #2175

nicolasbender opened this issue Jun 3, 2024 · 2 comments
Labels
help wanted Need some extra hands to get this done. status/discussion-needed Issue or PR that requires in-depth discussion. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@nicolasbender
Copy link

nicolasbender commented Jun 3, 2024

Description

Currently, different commands use different parameter names for building for a specific architecture. Here are few examples:

pack buildpack new uses --targets

pack builder create uses --target

pack build uses --platform

We noticed that this leads to confusion and also issues in help and log messages like the Pro-Tip for pack builder create which proposes --targets instead of the correct --target.

Proposed solution

Harmonization of the parameter names leads to a consistent experience for the user. Our proposal is to use an additional --targets alias for all commands which is based on the naming for the multi-arch properties in the toml configuration like stated in specs for buildpack.toml, image-extension.toml and Stacks-Removal-RFC96, Multi-Arch-RFC128.

@nicolasbender nicolasbender added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Jun 3, 2024
@jjbustamante
Copy link
Member

Hi @nicolasbender , thanks for filling this issue, sorry about the confusion, we actually added --platform to pack build in the very last minute before relasing pack 0.34.x because we noticed it behavior for M1 users could be broken. We still need to do more things for multi-platform, we will keep an eye on this.

@natalieparellano
Copy link
Member

I agree - we need to think through carefully when we're using targets to mean the run image and when we're using targets to mean the build image. Right now they MUST be the same platform, but in a world where that isn't necessarily the case we must explain ourselves.

@natalieparellano natalieparellano added this to the 0.36.0 milestone Jul 1, 2024
@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.37.0 Nov 12, 2024
@natalieparellano natalieparellano added status/discussion-needed Issue or PR that requires in-depth discussion. help wanted Need some extra hands to get this done. and removed status/triage Issue or PR that requires contributor attention. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/discussion-needed Issue or PR that requires in-depth discussion. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants