Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.buildpacks.builder.metadata is incorrect for builders that declare [[run.images]] in builder.toml #2143

Open
natalieparellano opened this issue Apr 26, 2024 · 0 comments
Labels
status/discussion-needed Issue or PR that requires in-depth discussion. type/bug Issue that reports an unexpected behaviour.
Milestone

Comments

@natalieparellano
Copy link
Member

Summary

This is our fault for not having a builder spec. But when we added [[run.images]] to builder.toml (which results in the run.toml file getting created within the builder) we didn't spec how that information would be declared in the io.buildpacks.builder.metadata label.

For reference, stack information is declared in that label with schema:

  "stack": {
    "runImage": {
      "image": "some-run-image",
      "mirrors": []
    }
  }

We probably want to declare run images information in that label with schema:

  "run": {
    "images": [
      {
        "image": "some-run-image",
        "mirrors": []
      }
    ]
  }

But again, we don't have a builder spec. Today, due to some struct sharing, that information is encoded as:

  "images": [
    {
      "image": "some-run-image",
      "mirrors": []
    }
  ]

This is confusing. We should also consider whether we want to encode any information about the build-time base (in absence of a stack ID this information is lost).

@natalieparellano natalieparellano added type/bug Issue that reports an unexpected behaviour. status/triage Issue or PR that requires contributor attention. labels Apr 26, 2024
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels May 23, 2024
@natalieparellano natalieparellano added this to the 0.36.0 milestone Jul 1, 2024
@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.37.0 Nov 12, 2024
@natalieparellano natalieparellano added status/discussion-needed Issue or PR that requires in-depth discussion. and removed status/ready Issue ready to be worked on. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/discussion-needed Issue or PR that requires in-depth discussion. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants