Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command pack manifest add to add an image to a manifest list #1719

Closed
1 task
Tracked by #294
jjbustamante opened this issue Apr 10, 2023 · 0 comments · Fixed by #1705
Closed
1 task
Tracked by #294

Add command pack manifest add to add an image to a manifest list #1719

jjbustamante opened this issue Apr 10, 2023 · 0 comments · Fixed by #1705
Labels
epic/multi-arch experimental Issue or PR refers to an experimental feature. good for mentorship A good issue for a mentorship project. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@jjbustamante
Copy link
Member

jjbustamante commented Apr 10, 2023

Context

We've been working on the idea to add multi-arch support on CNB. A mentorship project was created on LFX and this feature is part of the efforts to build the Minimal Viable Product (MVP) during the program duration.

More information can be found:

Description

When a manifest list already exists in the docker daemon or in a registry, sometimes the user expects to update it by adding a new image to the manifest list.

Proposed solution

A new feature on Pack can be implemented to help our users. The feature is inspired by the similar functionality in docker or podman

pack manifest add  [OPTIONS] <manifest-list> <manifest> 
  options:
   --all         If the image which should be added to the list or index is itself a list or index, add all of the contents to the local list
   --arch     Set the architecture 
   --os         Set the operating system
   --variant  Set the architecture variant

Describe alternatives you've considered

Additional context

  • This feature should be documented somewhere
@jjbustamante jjbustamante added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. experimental Issue or PR refers to an experimental feature. good for mentorship A good issue for a mentorship project. labels Apr 10, 2023
@jjbustamante jjbustamante moved this from Todo to In Progress in LFX 2023: Husni Faiz May 9, 2023
@jjbustamante jjbustamante added status/in-progress Issue or PR that is currently in progress. and removed status/triage Issue or PR that requires contributor attention. labels Aug 15, 2023
@jjbustamante jjbustamante added this to the 0.31.0 milestone Aug 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@natalieparellano natalieparellano modified the milestones: 0.33.0, 0.34.0 Dec 13, 2023
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Mar 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in LFX 2023: Husni Faiz May 8, 2024
@jjbustamante jjbustamante modified the milestones: 0.35.0, 0.34.0 May 8, 2024
@jjbustamante jjbustamante removed the status/in-progress Issue or PR that is currently in progress. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/multi-arch experimental Issue or PR refers to an experimental feature. good for mentorship A good issue for a mentorship project. type/enhancement Issue that requests a new feature or improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants