Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.21.0] Unable to pass complex env to pack build #1288

Closed
arjun024 opened this issue Sep 17, 2021 · 4 comments
Closed

[v0.21.0] Unable to pass complex env to pack build #1288

arjun024 opened this issue Sep 17, 2021 · 4 comments
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Milestone

Comments

@arjun024
Copy link

Summary

With v0.21, pack build fails when passed a complex build time env variable
like --env BP_GO_GENERATE_FLAGS='-run "^//go:generate sleep"'


Reproduction

Steps
  1. Clone and change directory to https://github.com/paketo-community/go-generate/blob/v0.0.5/integration/testdata/args_and_flags/main.go

  2. v0.20.0 (Success)

$ pack --version
0.20.0+git-66a4f32.build-2668

$ pack build goimage --builder paketobuildpacks/builder:full \
--env BP_GO_GENERATE_FLAGS='-run "^//go:generate sleep"'
...
...
Successfully built image goimage
  1. v0.21.0 (Failure)
$ /tmp/pack21 --version
0.21.0+git-a9c294a.build-2814

$ /tmp/pack21 build goimage21 --builder paketobuildpacks/builder:full \
--env BP_GO_GENERATE_FLAGS='-run "^//go:generate sleep"'
ERROR: failed to parse env line 'BP_GO_GENERATE_FLAGS=-run "^//go:generate sleep"': invalid syntax between 0 and 48

More Info

See Github Action failures associated with the 2 following Pull Requests that updates pack cli on integration test suite run by Paketo Buildpacks
paketo-community/go-generate#88
paketo-buildpacks/php-web#200


Environment

docker info
Client: Docker Engine - Community
 Version:           20.10.3
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        48d30b5
 Built:             Fri Jan 29 14:33:13 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.6
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       8728dd2
  Built:            Fri Apr  9 22:44:13 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.4
  GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
 runc:
  Version:          1.0.0-rc93
  GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
@arjun024 arjun024 added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Sep 17, 2021
@jromero jromero added good first issue A good first issue to get started with. status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Sep 17, 2021
@jromero
Copy link
Member

jromero commented Sep 17, 2021

Likely related to changes in #1212

@sambhav
Copy link
Member

sambhav commented Sep 17, 2021

This also seems to be impacting me. Any chance we could revert this behavior to what it was before?

@jromero
Copy link
Member

jromero commented Sep 17, 2021

Getting out a patch!

Resolved by e09e397

@sambhav
Copy link
Member

sambhav commented Sep 18, 2021

Thank you so much for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

No branches or pull requests

3 participants