Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack should allow setting a docker repository to pull lifecycle from #1083

Closed
1 task done
sambhav opened this issue Feb 18, 2021 · 4 comments · Fixed by #1088
Closed
1 task done

Pack should allow setting a docker repository to pull lifecycle from #1083

sambhav opened this issue Feb 18, 2021 · 4 comments · Fixed by #1088
Labels
type/enhancement Issue that requests a new feature or improvement.

Comments

@sambhav
Copy link
Member

sambhav commented Feb 18, 2021

Description

Often times, enterprises prevent access to the internet and have private registries. In cases such as these, pack doesn't allow you to run pack build unless your builder is trusted.

This is useful to allow private buildpacks/builders to function without having to configure each internal builder as trusted.

Proposed solution

Allow creating a pack config subcommand to set a lifecycle mirror repository which can be used instead of https://github.com/buildpacks/pack/blob/main/build.go#L44

Describe alternatives you've considered

Adding each and every builder as trusted

Additional context

  • This feature should be documented somewhere
@sambhav sambhav added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Feb 18, 2021
@dfreilich
Copy link
Member

This may help fix #904

@ekcasey
Copy link
Member

ekcasey commented Feb 19, 2021

@dfreilich fwiw I think configuring different (mirror) locations to find known lifecycle images is a bit different from allowing a user to pass an arbitrary lifecycle image. But doing the latter would provide a work around for the former.

@samj1912 I am curious, is you private registry truly a mirror of a public registry (same repo names, different registry hostname) or would you need to supply the reference for each mirrored image. I ask because it's possible to configure a a daemon with a mirror registry, but pack sometimes directly reaches out to image registries and I suspect would not respect this config. Enhancing pack to support mirror registries (rather than specific mirror images) might be another desirable feature, if this is a common use case.

@sambhav
Copy link
Member Author

sambhav commented Feb 19, 2021

It is not an exact mirror, rather a filtered version of it. Passing in an arbitrary lifecycle image would work as well.

@jromero
Copy link
Member

jromero commented Feb 23, 2021

I lean towards arbitrary lifecycle image as suggested in the review. It would be more versatile.

Big picture-wise, there is also another similar issue #821 which should enable other transparent/caching proxies. I don't think that these issues conflict given the different use cases.

  1. I want to use this very specific lifecycle image
  2. I want all my images to be pulled through this proxy

@jromero jromero removed the status/triage Issue or PR that requires contributor attention. label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants