Add execd helper #78
Merged
Add execd helper #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
added
semver:minor
Signed-off-by: Sambhav Kothari <[email protected]>
dmikusa
requested changes
Oct 4, 2021
There was a problem hiding this comment.
Not necessarily something we have to change, but I wanted to start a conversation about the naming of the primary type & function this change exposes.
I outlined a couple of options that I think might follow the terminology used in the spec a little more closely. IMHO, that would help someone trying to use the library as it's easy to see how the library fits with the spec.
sambhav
commented
Oct 5, 2021
There was a problem hiding this comment.
@dmikusa-pivotal just confirming if the suggested names look okay.
Signed-off-by: Sambhav Kothari <[email protected]>
dmikusa
approved these changes
Oct 5, 2021
hone
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality in libcnb to define execd interfaces easily.