Use appropriate bindings path for detect #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sambhav Kothari <[email protected]>
sambhav
commented
Jan 5, 2022
| file = filepath.Join(ctx.Platform.Path, "bindings") | ||
| if ctx.Platform.Bindings, err = NewBindingsFromPath(file); err != nil { | ||
| config.exitHandler.Error(fmt.Errorf("unable to read platform bindings %s\n%w", file, err)) | ||
| if ctx.Platform.Bindings, err = NewBindingsForBuild(ctx.Platform.Path); err != nil { |
There was a problem hiding this comment.
Looking back at this - I don't like that we call this NewBindingsForBuild - we should update it to something better in v2. cc: @dmikusa-pivotal
sambhav
added
semver:patch
dmikusa
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sambhav Kothari [email protected]
Fixes #105