Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semvar for version checking #132

Closed
gcemaj opened this issue Apr 5, 2022 · 0 comments · Fixed by #134
Closed

Use semvar for version checking #132

gcemaj opened this issue Apr 5, 2022 · 0 comments · Fixed by #134
Labels
semver:patch A change requiring a patch version bump type:task A general task

Comments

@gcemaj
Copy link

gcemaj commented Apr 5, 2022

Currently version checking is done via strings which limits the ability to do things like

Feature only supported for versions greater than x.y.z

Switching this to semvar would enable this type of feature gating
@sambhav sambhav added type:task A general task semver:patch A change requiring a patch version bump good first issue labels Apr 5, 2022
@gcemaj gcemaj mentioned this issue Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add semver checks gcemaj/libcnb
2 participants
@gcemaj @sambhav