Manifest List Interface #191
Conversation
husni-faiz
force-pushed
the
dev-image-index
branch
from
4ed6787 to
e267ed4
Compare
husni-faiz
force-pushed
the
dev-image-index
branch
5 times, most recently
from
f7314e6 to
0ca19aa
Compare
husni-faiz
force-pushed
the
dev-image-index
branch
from
111bb42 to
2fcc6b5
Compare
husni-faiz
force-pushed
the
dev-image-index
branch
5 times, most recently
from
742529c to
1c5039d
Compare
The OCI spec defines an Image Index concept to handle multiple manifests in an OCI image. This adds the interface for Image Index. Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
remote.Image uses descriptor to get the image. Getting the descriptor first and deriving the image from the descriptor is efficient instead of getting the descriptor twice. Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
remote/new.go
Outdated
|
|
||
| // ValidateRepoName | ||
| // TODO move this code to something more generic | ||
| func validateRepoName(repoName string, o *imgutil.IndexOptions) error { |
There was a problem hiding this comment.
This function will be more re-usable if it just accepts an insecure bool, instead of index options. Then we can use it for images too.
There was a problem hiding this comment.
I agreed, honestly I put it here just to remember me to do something with it later!
There was a problem hiding this comment.
Just a note, we're not actually validating the "repo name" for remote images today (though maybe we should). I think I removed it in husni-faiz#12, but we could add it back.
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Few more simplifications
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
More cleanup
…oid getting rate limited Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
…h signature Signed-off-by: Juan Bustamante <[email protected]>
… save the image information. Reimplement the getters/setters to read the information from the index. Adding more test coverage Signed-off-by: Juan Bustamante <[email protected]>
| if err != nil { | ||
| return "", err | ||
| } | ||
| return configFile.OS, nil | ||
| if desc.Platform != nil { |
There was a problem hiding this comment.
nit: getDescriptorFrom never returns nil in its first argument, so I think you can remove this check
There was a problem hiding this comment.
I think I added it because on unit testing when using random packages in ggcr some nil in these attributes but let me check if everything is file after removing it
…efined Signed-off-by: Juan Bustamante <[email protected]>
…o the index Push method Signed-off-by: Juan Bustamante <[email protected]>
cnb_index.go
Outdated
| multiWriteTagables[ref.Context().Tag(tag)] = taggableIndex | ||
| } | ||
|
|
||
| // FIXME: this will only push the index manifest, assuming that all the images it refers to exist in the registry |
There was a problem hiding this comment.
I think this is not a FIXME, I tried to remove it and use the remote.WriteIndex but in such a case we need to have everything on disk in OCI layout format.
I think we should document this behavior for library consumers. For example:
- I want to create my own index at
repo/fooand include some busybox manifests, first you need tocopythe busybox manifests torepo/foobefore pushing the index otherwise it fails
Signed-off-by: Juan Bustamante <[email protected]>
…override with OCI media-type Signed-off-by: Juan Bustamante <[email protected]>
|
@jabrown85 I think this one is just about ready if you'd like to take a look. I turned on squashing for PRs so that we can bring this into main as one commit 😅 |
Signed-off-by: Juan Bustamante <[email protected]>
Hi all,
I am working on the issue #188 to create a ManifestList/ImageIndex interface as part of a larger scope of adding multi-architecture support to buildpacks. I would appreciate your ideas and thoughts on how we want to move forward. There is a lot of validations and test to be added along the line.
In parallel a pack-cli command
manifestis being developed to work with Manifest Lists.You may find the following resources useful.
Fixes #188