Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upx from build #223

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Remove upx from build #223

merged 1 commit into from
Aug 3, 2023

Conversation

jkutner
Copy link
Member

@jkutner jkutner commented Aug 3, 2023

The upx package is no longer available for debian and newer versions of the golang base image. Because upx has caused us some issues locally with Crowdstrike, we are removing it from the build process.

This increases the size of the github-actions images by about 3MB each

Signed-off-by: Joe Kutner <[email protected]>
@jkutner jkutner requested review from a team as code owners August 3, 2023 16:06
@jkutner jkutner added type:task A general task semver:patch A change requiring a patch version bump labels Aug 3, 2023
@jkutner jkutner enabled auto-merge August 3, 2023 16:06
@jkutner jkutner merged commit 958a531 into main Aug 3, 2023
@jkutner jkutner deleted the jkutner/fix-build branch August 3, 2023 16:07
@edmorley
Copy link
Contributor

edmorley commented Aug 4, 2023

This increases the size of the github-actions images by about 3MB each

I think that must be the uncompressed image size, since the layer metadata for the binary's layer reports the gzipped size as only increasing from 2,165,499 to 2,368,134 bytes:
https://github.com/orgs/buildpacks/packages/container/actions%2Fregistry%2Frequest-add-entry/92224166?tag=5.2.0
https://github.com/orgs/buildpacks/packages/container/actions%2Fregistry%2Frequest-add-entry/115507685?tag=5.3.1
(the manifest is shown at the bottom of each of those pages)

As such the bytes over the wire barely changed (which for CI use-cases is more important than bytes on disk) - further validating the decision to simplify things here and remove UPX :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants