Don't hardcode linux/amd64 or GO111MODULE in Dockerfile #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fewer-hardcoded-assumptions
branch
2 times, most recently
from
cddc4e4 to
914521e
Compare
DrJosh9000
force-pushed
the
fewer-hardcoded-assumptions
branch
from
914521e to
21fa12a
Compare
CerealBoy
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GO111MODULE=onhas been the default for... a while now.GOARCH=arm64gets in the way of building a usable image if you just want the current arch.GOOS=linuxis possibly still relevant. 🤔Other tweaks:
apk add --no-cacheFROMvsas)