Delete Prometheus labels for deleted queues #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
remove-deleted-queues
branch
from
4ca0c98 to
0cd0210
Compare
DrJosh9000
changed the title
|
@DrJosh9000 Another good pickup, I was interested in the note on order in https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#MetricVec.DeleteLabelValues and recommendation to use https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#MetricVec.Delete instead. |
DrJosh9000
force-pushed
the
remove-deleted-queues
branch
from
0cd0210 to
152e57a
Compare
|
Good call @wolfeidau! I've changed a couple of other label-related things to be similar while here. |
This was referenced Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Track which queues are present in the most recent Collect for each cluster, and delete them from the metrics when they are no longer there.
Possible fix for #304
Why
#296 removed some code that was well-intentioned, but heavy-handed, and didn't make sense in a setup monitoring more than one cluster (or a cluster and unclustered...) But then there was nothing to remove old queues, which is a potential memory issue (minor) and causes metrics for deleted queues to get stuck on the last value (confusing).