Adding more debug traces for HTTP and enhance security #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
reviewed
May 21, 2024
- Updating debug request to redact Authorisation header.
* `return nil` instead of `return err` where `err` is unrelated * `if err != nil` rather than `if err == nil` * more precise token redaction
log.Print includes a timestamp by default, and debug logging is stderr-flavoured output. The only tweaks needed are to log with more precise timestamps
DrJosh9000
force-pushed
the
junjung/adding-more-logs
branch
from
60b1f35 to
d78130f
Compare
DrJosh9000
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
To debug sudden spiking delay while collecting and processing metrics, it was required to collect more metrics during the HTTP requests.
Also, we noticed that the agent token is exposed to the log when HTTP debug is enabled, which can be a security risk.
This PR
It adds more traces to the HTTP Client tracer for more detailed event timing. Also, it updates the request dump to redact the Authorisation header if it exists.