Ignore cluster if it is empty #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
pdp-1943-ignore-cluster-if-it-is-empty
branch
from
b543f68 to
1cd3bb7
Compare
\#227 added support for clusters, but as was somewhat anticipated, it broke compatibility with the some existing backends because it added a new dimension/label/tag or some equivalent for the cluster. In this PR, we refrain from doing so if the cluster is the empty string. One thing to note is that the cluster is not specified when the process starts, it is encoded in the cluster token, and the backend include the name of the cluster in its response. If the token is for unclustered agents, that part of the response will be the empty string.
triarius
force-pushed
the
pdp-1943-ignore-cluster-if-it-is-empty
branch
from
1cd3bb7 to
a2fd1bc
Compare
DrJosh9000
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#227 added support for clusters, but as was somewhat anticipated, it
broke compatibility with some existing backends because it added a
new dimension/label/tag or some equivalent for the cluster. In this PR,
we refrain from doing so if the cluster is the empty string.
One thing to note is that the cluster is not specified when the process
starts, it is determined from the cluster token by the backend which includes the name
of the cluster in its response. If the token is for unclustered agents,
that part of the response will be the empty string.