Moved collector into subpackage with tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
suggested changes
Dec 18, 2016
| agents := v.([]bk.Agent) | ||
|
|
||
| for _, agent := range agents { | ||
| queue := "default" |
There was a problem hiding this comment.
An agent can have multiple queues. I have this bug too in the new queues API endpoint, so the numbers were a little off. We'll need to fix that here too.
There was a problem hiding this comment.
ORLY? That's interesting. I will keep this behaviour in currently and look to fix it in a subsequent PR.
callumj
reviewed
Dec 19, 2016
| func New(c *bk.Client, opts Opts) *Collector { | ||
| return &Collector{ | ||
| Opts: opts, | ||
| buildService: c.Builds, |
There was a problem hiding this comment.
Just noticed this in my local copy (I'm doing a fork to add statsd support): should agentService be populated too?
There was a problem hiding this comment.
Hrm, good point, now to figure out how it works at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out not having tests sucks, as does having loads of code in the main package. This remedies both of these things to a minimal extent.