Make the timeout configurable #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@triarius could I be a pain and ask you to merge this in for me? I don't seem to have 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the http
timeoutis set to 15 seconds, which is mostly fine. However, if folks are seeing timeouts occur it might be nice if we let them adjust the timeout on the http calls so that they can test prior to raising an issue. This change ensures that the default remains at 15 seconds, which may or may not have been picked for a reason, where someone doesn't opt to set it, but gives the option to do so. It also doesn't create a global increase of timeouts.