Update release process to generate checksums #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
oss-194-release-checksums
branch
2 times, most recently
from
867cfa7 to
c47209c
Compare
This is an extra check that the job is running a tag build.
triarius
force-pushed
the
oss-194-release-checksums
branch
from
99ed038 to
4895c1a
Compare
I think it's better that the release candidate branches are NOT namespaced by their author so that there is some kind of barrier preventing multiple authors from releasing at the same time. Of course this dose not replace proper communication in the organisation which should be the primary way to ensure this does not happen.
|
@moskyb I snuck in another commit after your review, but I think it's a pretty uncontroversial documentation change. LMK if you think otherwise. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the opportunity to replace the rather old buildkite/github-release tool with the more modern github cli.
I also changed the release steps to run on tags rather than a master branch build. It is difficult to find which master branch build actually made a release amongst the vast majority of master branch builds that do not make a release.
Now, the release process will require a human to manually tag the merge commit for the changelog PR. Pushing that tag will cause a draft release to be created on GitHub, which a human can approve and publish.
Fixes: #138