Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize http.Client collector configurations #121

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Standardize http.Client collector configurations #121

merged 1 commit into from
Jun 10, 2022

Conversation

alloveras
Copy link
Contributor

Intent

The current implementation will use two different http.Client configurations depending on whether the collector is targetting ALL queues or only particular ones.

Problem

When targetting particular queues, the code will use http.DefaultClient and, as a consequence of its default values, it will use an infinite client timeout. This is particularly problematic as upstream servers may not have timeouts set either or use a very long one. Hence, when used in the Lambda environment, a bad behaving request can force the function execution time to skyrocket and go past the Lambda execution timeout.

Solution

To ensure that both configurations (all queues vs particular queues) do use the same HTTP client configurations with a sensible client timeout value.

@moskyb moskyb merged commit c107546 into buildkite:master Jun 10, 2022
@alloveras alloveras deleted the patch-1 branch June 10, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants