Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite-agent-metrics should accept BUILDKITE_AGENT_TOKEN #115

Closed
cole-h opened this issue Jul 15, 2021 · 0 comments · Fixed by #116
Closed

buildkite-agent-metrics should accept BUILDKITE_AGENT_TOKEN #115

cole-h opened this issue Jul 15, 2021 · 0 comments · Fixed by #116

Comments

@cole-h
Copy link
Contributor

cole-h commented Jul 15, 2021 •
edited
Loading

Instead of requiring it to be passed in plaintext on the command line, buildkite-agent-metrics should allow the token to be specified by the same env var as the lambda tool, because passing it via argv is insecure.

buildkite-agent-metrics/main.go

Line 54 in 1d0ac29

if *token == "" {

@cole-h cole-h changed the title buildkite-agent-metrics should accept BUILDKITE_AUTH_TOKEN buildkite-agent-metrics should accept BUILDKITE_AGENT_TOKEN Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support getting agent token from BUILDKITE_AGENT_TOKEN env var
1 participant
@cole-h