Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-Up "Identity.Application" cookie properly #166

Open
simon-wacker opened this issue May 31, 2023 · 0 comments
Open

Clean-Up "Identity.Application" cookie properly #166

simon-wacker opened this issue May 31, 2023 · 0 comments

Comments

@simon-wacker
Copy link
Contributor

simon-wacker commented May 31, 2023

Currently, the cookie is added in

var signInResult = await signInManager.PasswordSignInAsync(
, used in
var result = await AuthenticateAsync(AuthConfiguration.IdentityConstantsApplicationScheme).ConfigureAwait(false);
, and deleted in
return await DoSignIn(principal).ConfigureAwait(false);
and
await _signInManager.SignOutAsync().ConfigureAwait(false);
. In the user interface, this corresponds to navigating to /connect/authorize, being redirected to the login screen in which user name and password is entered, creating the cookie through the GraphQL endpoint, getting redirected to the consent page, and pressing the buttons accept or deny. If the user does not press accept or deny but just navigates to some other page, then the cookie is never deleted. It will stay as long as session cookies live in the user's web browser or until the user does another login attempt and presses accept or deny buttons.

@github-actions github-actions bot added the triage Review issue to make sure it is relevant, actionable, and has all the necessary information label May 31, 2023
@simon-wacker simon-wacker removed the triage Review issue to make sure it is relevant, actionable, and has all the necessary information label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant