Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input root to sub directory of build directory #20

Closed
Qinusty opened this issue Aug 30, 2019 · 2 comments
Closed

Move input root to sub directory of build directory #20

Qinusty opened this issue Aug 30, 2019 · 2 comments

Comments

@Qinusty
Copy link
Contributor

Qinusty commented Aug 30, 2019

That said, one change we should consider making to Buildbarn at some point is that we do move the input root into some kind of subdirectory, reserving the top-level directory for other storage purposes. For example, stdout and stderr of build actions are currently stored as files inside the input root. So like this:

input_root
├── .stdout.txt
├── .stderr.txt
├── input_file.c
└── output_file.o

Though most build actions generally don't care about that, it's a bit sloppy. If a build action would try to tar its entire input root, it would also archive its own stdout/stderr logs. We should consider restructuring it to something like this:

build_directory
├── stdout.txt
├── stderr.txt
└── input_root
    ├── input_file.c
    └── output_file.o

Originally posted by @EdSchouten in #18 (comment)

@Qinusty
Copy link
Contributor Author

Qinusty commented Sep 5, 2019

When doing this, it will be important to ensure that the runner executes the action under the input_root to ensure any provided toolchains are used. Buildstream supplies a full sandbox environment as it's input_files and as such autoconf may be expected to exist under $PATH, which could be placed at /bin, /usr/bin etc.

@EdSchouten
Copy link
Member

This has been fixed now. Builds take place in a root subdirectory. The stdout and stderr logs are no longer prefixed with a dot, making it easier to find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants