-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test case can not pass in /code/ch3.3/cpu.rs #9
Comments
Hey @123zmz123. Thank you for pointing this out! You might be right. Do you mind creating a PR ? I would be very grateful :) |
Cool! wait for me. |
ch5.1 also have this issue. Test 'test_0xaa_tax_move_a_to_x' and 'test_inx_overflow' will not pass because load_and_run() will call reset(), which reset all variables to default value. |
Commit 1a4e5f5 fixed the ch3.3, but all subsequent chapters have the same problem which is still unfixed. There were other ways this could have been fixed. Personally I would have kept using the
So not a full reset, but just re-read 0xFFFC after loading something. In general there are quite a few unit tests failing, which was causing me confusing whilst following this great tutorial. In addition, I'm getting quite a few compiler warnings (E.g. Unused imports and naming conventions on enums). I can create a separate pull request for that. |
Actually, just noticed pull request #12 does exactly what I was suggesting above, but we still need to do this for all the subsequent chapters. Do you still have time to work on this project? It would be a shame for this to gradually rot, just as Rust is about to hit the big time. I've really enjoyed following it so far; I'm about 1/2 way through. |
seems like we need comment 3 line to pass the test.
The text was updated successfully, but these errors were encountered: