Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin panel's execution history doesn't support bash formatting #165

Closed
shinebayar-g opened this issue Jan 15, 2019 · 2 comments
Closed

Comments

@shinebayar-g
Copy link
Collaborator

I've this bash script with color formatting. It has some visual bugs when executing this type of files (I couldn't catch what is exactly bugging this, but I'll find it and probably raise an another issue)

If I check execution history from admin panel these type of scripts looks like this:

�[1m01:34:11 : Changing directory to service�[0m
�[1m01:34:11 : Pulling update from master�[0m
From https://github.com/user/repo
 * branch            master     -> FETCH_HEAD
Already up to date.
�[1m01:34:11 : Changing directory to user-base�[0m
�[1m01:34:11 : Pulling update from master�[0m
From https://github.com/user/user-base
 * branch            master     -> FETCH_HEAD
Already up to date.

image

original script is:

#!/bin/bash
now=$(date +"%T")

# Pull changes
echo -e "\e[1m\e[34m$now : Changing directory to service\e[0m"
cd /home/shinee/service/service

echo -e "\e[1m\e[34m$now : Pulling update from master\e[0m"
git pull origin master

echo -e "\e[1m\e[34m$now : Changing directory to user-base\e[0m"
cd /home/shinee/service/user-base

echo -e "\e[1m\e[34m$now : Pulling update from master\e[0m"
git pull origin master
cd /home/shinee/service
@bugy bugy added the feature label Jan 15, 2019
@bugy
Copy link
Owner

bugy commented Jan 15, 2019

Hi, this is expected behaviour. On admin panel I'm showing raw output without any processing, to avoid possible confusion caused by invalid formatting or weird script outputs.

I'll keep this ticket for make output type (raw/formatted) configurable (probably via checkbox on UI)

@bugy
Copy link
Owner

bugy commented Mar 20, 2019

So, after finishing #174, admin terminal will always show formatted output. I would create a separate ticket to make it configurable (raw/formatted)

@bugy bugy added this to the 1.14 milestone Mar 20, 2019
@bugy bugy added the resolved label Mar 20, 2019
@bugy bugy closed this as completed Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants