Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid public API key source map uploads #1933

Open
Miljoen opened this issue Feb 24, 2023 · 1 comment
Open

Avoid public API key source map uploads #1933

Miljoen opened this issue Feb 24, 2023 · 1 comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature

Comments

@Miljoen
Copy link

Miljoen commented Feb 24, 2023

Description

Is your feature request related to a problem?

Yes, when using Bugsnag on the client side, the API key is public.
From this issue:
"They would in theory be able to send fake reports / source maps to your dashboard ..."
The fake reports are not my concern here, the fake source maps on the other hand are.

Describe the solution you'd like
Keep the public API key, but avoid any user being able to upload source maps.
In other words, create a separate API key for uploading source maps specifically (this one can be kept secret).

Additional context
We automate uploading source maps on tag releases, and we must be able to rely on correct source maps for our released tag.
When we add Bugsnag to client side projects (TS), we must provide the API key to be able to upload bug reports.
But this same key can be used to corrupt our source maps.

Additional remark: anyone could in theory upload anything, even malicious scripts.

The best way forward in my view is to limit the public bug reporting API key to what it is supposed to do, sending bug reports.

@johnkiely1
Copy link
Member

Hi @Miljoen

We actually have an existing item on our product roadmap to use a separate API key for source map uploads. This would mean that the upload API key could be kept private, preventing people from uploading modified source maps using the public API key.

I don't have a firm ETA for this but I've flagged your interest with our product team and we'll be sure to keep you posted with any updates.

@johnkiely1 johnkiely1 added feature request Request for a new feature backlog We hope to fix this feature/bug in the future labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants