Skip to content

Commit

Permalink
Disable maze trace validation until PIPE-7498 is done
Browse files Browse the repository at this point in the history
  • Loading branch information
DariaKunoichi committed Nov 8, 2024
1 parent 1768147 commit c64c7d2
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 15 deletions.
4 changes: 2 additions & 2 deletions bugsnag_performance.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ func createBugsnagMergedResource() *resource.Resource {
Value: attribute.StringValue(Config.AppVersion),
},
{
Key: bugsnagTelemetrySDKName,
Key: bugsnagSDKNameAttribute,
Value: attribute.StringValue(sdkName),
},
{
Key: bugsnagTelemetrySDKVer,
Key: bugsnagSDKVersionAttribute,
Value: attribute.StringValue(Version),
},
}
Expand Down
22 changes: 11 additions & 11 deletions consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ package bugsnagperformance
import "time"

const (
samplingAttribute = "bugsnag.sampling.p"
samplingResponseHeader = "Bugsnag-Sampling-Probability"
samplingRequestHeader = "Bugsnag-Span-Sampling"
fetcherRetryInterval = 30 * time.Second
fetcherRefreshInterval = 24 * time.Hour
fetcherRequestBody = `{"resourceSpans": []}`
deploymentEnvAttribute = "deployment.environment"
serviceVersionAttribute = "service.version"
bugsnagTelemetrySDKName = "bugsnag.telemetry.sdk.name"
bugsnagTelemetrySDKVer = "bugsnag.telemetry.sdk.version"
sdkName = "Go Bugsnag Performance SDK"
samplingAttribute = "bugsnag.sampling.p"
samplingResponseHeader = "Bugsnag-Sampling-Probability"
samplingRequestHeader = "Bugsnag-Span-Sampling"
fetcherRetryInterval = 30 * time.Second
fetcherRefreshInterval = 24 * time.Hour
fetcherRequestBody = `{"resourceSpans": []}`
deploymentEnvAttribute = "deployment.environment"
serviceVersionAttribute = "service.version"
bugsnagSDKNameAttribute = "bugsnag.telemetry.sdk.name"
bugsnagSDKVersionAttribute = "bugsnag.telemetry.sdk.version"
sdkName = "Go Bugsnag Performance SDK"
)
2 changes: 1 addition & 1 deletion delivery.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func createDelivery() *delivery {
func (d *delivery) send(headers map[string]string, payload []byte) (*http.Response, error) {
newHeaders := map[string]string{}

// TODO - add this back when pipeline is prepared to handle it
// TODO - can be restored after https://smartbear.atlassian.net/browse/PIPE-7498
//newHeaders["Bugsnag-Sent-At"] = time.Now().Format(time.RFC3339)

// merge constant headers with the headers passed in
Expand Down
2 changes: 1 addition & 1 deletion delivery_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func TestHeadersPresentAtSend(t *testing.T) {
if r.Header.Get("key1") != "value1" {
t.Errorf("Expected header key1 to be value1, got %s", r.Header.Get("key1"))
}
// TODO - add this back when pipeline is ready
// TODO - can be restored after https://smartbear.atlassian.net/browse/PIPE-7498
//if r.Header.Get("Bugsnag-Sent-At") == "" {
// t.Errorf("Expected header Bugsnag-Sent-At to be present")
//}
Expand Down
2 changes: 2 additions & 0 deletions features/support/env.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Before do
# we don't need to send the integrity header
Maze.config.enforce_bugsnag_integrity = false
# TODO - can be restored after https://smartbear.atlassian.net/browse/PIPE-7498
Maze.config.skip_default_validation('trace')
$address = nil
steps %(
When I configure the maze endpoint
Expand Down

0 comments on commit c64c7d2

Please sign in to comment.