fix: Use latest value when checking release stage #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
kattrali/fix-release-stages-filtering
branch
from
445cffd
to
c0c5384
Compare
A serialization bug in crash reports would erroneously allow or prevent crash reports from being delivered when the value of release stage or notify release stages were changed after start() was called, or in a subsequent build of the same app. Some values in config are serialized as nested values, while others are at the "top" level of config when written to disk. This change checks the expected position and fallback value for every config option. Fixes #405
kattrali
force-pushed
the
kattrali/fix-release-stages-filtering
branch
from
c0c5384
to
c5bfccc
Compare
The previous implementation reported the release stage when the report is sent, rather than when the report was generated. This change refactors the app state parser to use the correct stage value, either current or from a file cache.
kattrali
force-pushed
the
kattrali/fix-release-stages-filtering
branch
from
c5bfccc
to
ce91abb
Compare
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 51.83% 51.93% +0.09%
==========================================
Files 66 66
Lines 7522 7527 +5
==========================================
+ Hits 3899 3909 +10
+ Misses 3623 3618 -5
Continue to review full report at Codecov.
|
kattrali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A serialization bug in crash reports would erroneously allow or prevent
crash reports from being delivered when the value of release stage
or notify release stages were changed after start() was called, or in a
subsequent build of the same app.
Some values in config are serialized as nested values, while others are
at the "top" level of config when written to disk. This change checks
the expected position and fallback value for every config option.
Fixes #405