Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
robinmacharg committed Feb 12, 2020
1 parent c34f135 commit ac0775d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 31 deletions.
6 changes: 2 additions & 4 deletions Source/BugsnagMetadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,10 @@
- (id _Nullable)getMetadata:(NSString *_Nonnull)sectionName
key:(NSString *_Nonnull)key;

- (void)clearMetadataInSection:(NSString *_Nonnull)section
NS_SWIFT_NAME(clearMetadata(_:));
- (void)clearMetadataInSection:(NSString *_Nonnull)section;

- (void)clearMetadataInSection:(NSString *_Nonnull)section
key:(NSString *_Nonnull)key
NS_SWIFT_NAME(clearMetadata(_:key:));
key:(NSString *_Nonnull)key;

- (NSDictionary *_Nonnull)toDictionary;

Expand Down
4 changes: 0 additions & 4 deletions iOS/Bugsnag.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
000E6EA423D8AC8C009D8194 /* README.md in Resources */ = {isa = PBXBuildFile; fileRef = 000E6EA023D8AC8C009D8194 /* README.md */; };
000E6EA523D8AC8C009D8194 /* VERSION in Resources */ = {isa = PBXBuildFile; fileRef = 000E6EA123D8AC8C009D8194 /* VERSION */; };
000E6EA623D8AC8C009D8194 /* CHANGELOG.md in Resources */ = {isa = PBXBuildFile; fileRef = 000E6EA223D8AC8C009D8194 /* CHANGELOG.md */; };
004753D423F1A4E2009884EB /* BugsnagSwiftMetadataTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 004753D323F1A4E2009884EB /* BugsnagSwiftMetadataTests.swift */; };
00D7ACAD23E9C63000FBE4A7 /* BugsnagTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 00D7ACAC23E9C63000FBE4A7 /* BugsnagTests.m */; };
00D7ACAF23EABBC800FBE4A7 /* BugsnagSwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 00D7ACAE23EABBC800FBE4A7 /* BugsnagSwiftTests.swift */; };
4B47970A22A9AE1F00FF9C2E /* BugsnagEventFromKSCrashReportTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B47970922A9AE1F00FF9C2E /* BugsnagEventFromKSCrashReportTest.m */; };
Expand Down Expand Up @@ -414,7 +413,6 @@
000E6EA023D8AC8C009D8194 /* README.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
000E6EA123D8AC8C009D8194 /* VERSION */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = VERSION; path = ../VERSION; sourceTree = "<group>"; };
000E6EA223D8AC8C009D8194 /* CHANGELOG.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = CHANGELOG.md; path = ../CHANGELOG.md; sourceTree = "<group>"; };
004753D323F1A4E2009884EB /* BugsnagSwiftMetadataTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BugsnagSwiftMetadataTests.swift; sourceTree = "<group>"; };
00D7ACAC23E9C63000FBE4A7 /* BugsnagTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = BugsnagTests.m; path = ../../Tests/BugsnagTests.m; sourceTree = "<group>"; };
00D7ACAE23EABBC800FBE4A7 /* BugsnagSwiftTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BugsnagSwiftTests.swift; sourceTree = "<group>"; };
4B3B193422CA7B0900475354 /* BugsnagCollectionsBSGDictSetSafeObjectTest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = BugsnagCollectionsBSGDictSetSafeObjectTest.m; path = ../../Tests/BugsnagCollectionsBSGDictSetSafeObjectTest.m; sourceTree = "<group>"; };
Expand Down Expand Up @@ -644,7 +642,6 @@
children = (
000E6E9D23D8690F009D8194 /* BugsnagSwiftConfigurationTests.swift */,
00D7ACAE23EABBC800FBE4A7 /* BugsnagSwiftTests.swift */,
004753D323F1A4E2009884EB /* BugsnagSwiftMetadataTests.swift */,
);
path = "Swift Tests";
sourceTree = "<group>";
Expand Down Expand Up @@ -1271,7 +1268,6 @@
F4295995C3259BF7D9730BC4 /* BugsnagKSCrashSysInfoParserTest.m in Sources */,
E70E52152216E41C00A590AB /* BugsnagSessionTrackerStopTest.m in Sources */,
F4295F017754324FD52CCE46 /* RegisterErrorDataTest.m in Sources */,
004753D423F1A4E2009884EB /* BugsnagSwiftMetadataTests.swift in Sources */,
00D7ACAF23EABBC800FBE4A7 /* BugsnagSwiftTests.swift in Sources */,
F42952D83435C02F8D891C40 /* BugsnagThreadTest.m in Sources */,
4B47970A22A9AE1F00FF9C2E /* BugsnagEventFromKSCrashReportTest.m in Sources */,
Expand Down
23 changes: 0 additions & 23 deletions iOS/BugsnagTests/Swift Tests/BugsnagSwiftMetadataTests.swift

This file was deleted.

0 comments on commit ac0775d

Please sign in to comment.