Increase resilience of NDK stackframe method capture #1484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Increases the resilience of the code used to instantiate a
StackTraceElement
object when callingbugsnag_notify_env
. There were a couple of potential issues with the existing implementation:filename
andmethod
weren't checked forNULL
, which could lead to exceptions being thrown inbsg_safe_new_object
calloc
was not checked forNULL
, which could lead to a malformed string ifbsg_safe_new_string_utf
failed, resulting in a SIGABRTTesting
Relied on existing test coverage.