-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support blocking notify #1600
Comments
Hi @pyricau, Thanks for the suggestion. This seems like a reasonable feature request so we've added this to our roadmap. With that in mind, it would be great to find out a little more about your use case - are you just reporting 'handled' errors within the app under test? What about any unhandled crashes - presumably you would want to know about those as well? |
Those are actually unhandled crashes. We don't let bugsnag capture unhandled crashes automatically, we have our own exception handler and delegate to bugsnag (another missing API here is the ability to pass in the "unhandled" flag, which we currently do by hacking around the bugsnag API) |
Cheers for the details. Following some discussion, we're leaning more towards a callback based API to confirm completion of upload of the report. We'll keep you posted with updates on this on the thread. As for setting a handled report as unhandled, for your use case, you could use the isUnhandled property in a callback if this makes adjusting this easier for you? |
OH. I had missed this one, will absolutely try. Thanks! |
Description
We've set up Bugsnag in our UI tests to report failures to a central place and track crashes that cause random failures / flaky tests in CI. We call Bugsnag.notify() to report those.
Unfortunately,
Bugsnag.notify()
is async by nature, so if the test finishes before the upload then the VM is killed and the app is uninstalled, so we sometimes never get crash reported. I fixed this with some reflection hack to reach into Bugsnag's internals for now.Ideally, we'd either get a new
Client.notifyBlocking()
API, or a callback based API to know when the provided throwable is done being uploaded.The text was updated successfully, but these errors were encountered: