Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blocking notify #1600

Open
pyricau opened this issue Feb 7, 2022 · 4 comments
Open

Support blocking notify #1600

pyricau opened this issue Feb 7, 2022 · 4 comments
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature

Comments

@pyricau
Copy link
Contributor

pyricau commented Feb 7, 2022

Description

We've set up Bugsnag in our UI tests to report failures to a central place and track crashes that cause random failures / flaky tests in CI. We call Bugsnag.notify() to report those.

Unfortunately, Bugsnag.notify() is async by nature, so if the test finishes before the upload then the VM is killed and the app is uninstalled, so we sometimes never get crash reported. I fixed this with some reflection hack to reach into Bugsnag's internals for now.

Ideally, we'd either get a new Client.notifyBlocking() API, or a callback based API to know when the provided throwable is done being uploaded.

@yousif-bugsnag yousif-bugsnag added awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. feature request Request for a new feature labels Feb 14, 2022
@yousif-bugsnag
Copy link
Contributor

yousif-bugsnag commented Feb 14, 2022

Hi @pyricau,

Thanks for the suggestion. This seems like a reasonable feature request so we've added this to our roadmap.

With that in mind, it would be great to find out a little more about your use case - are you just reporting 'handled' errors within the app under test? What about any unhandled crashes - presumably you would want to know about those as well?

@pyricau
Copy link
Contributor Author

pyricau commented Mar 15, 2022

Those are actually unhandled crashes. We don't let bugsnag capture unhandled crashes automatically, we have our own exception handler and delegate to bugsnag (another missing API here is the ability to pass in the "unhandled" flag, which we currently do by hacking around the bugsnag API)

@mattdyoung mattdyoung removed the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Mar 18, 2022
@xljones
Copy link

xljones commented Mar 21, 2022

Cheers for the details. Following some discussion, we're leaning more towards a callback based API to confirm completion of upload of the report. We'll keep you posted with updates on this on the thread.

As for setting a handled report as unhandled, for your use case, you could use the isUnhandled property in a callback if this makes adjusting this easier for you?

@xljones xljones added the backlog We hope to fix this feature/bug in the future label Mar 21, 2022
@pyricau
Copy link
Contributor Author

pyricau commented Mar 28, 2022

As for setting a handled report as unhandled, for your use case, you could use the isUnhandled property in a callback if this makes adjusting this easier for you?

OH. I had missed this one, will absolutely try. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants