-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document uniqueness of name
on Organization
and User
#7
Conversation
I could go either way on the meat of this - moving the unique fields above the If we did do this, you'd need to update the comments globally, not just for one package (ie all of the |
I updated this PR to just be about copying the documentation for uniqueness on the field itself. Can consider re-ordering fields in a separate PR. |
Yeah, I figured.
Not sure what you mean here. It isn't clear to me that we would want to re-order In any case, after some reflection, I think adding docs to the field is sufficient (which is what this PR diff now is), and we don't need to go so far as changing the order of or renaming the fields. |
Yea looking into it, we actually do have "uniqueness" comments on the |
Document the uniqueness of the
name
field on the field itself.Closes #2