Remove buf.yaml and buf.lock as part of API by sending over structured module and dependency content #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #17 as #16 was closed.
This removes the sending of
buf.yaml
andbuf.lock
files over the wire, and consequently these being part of the structure ofModules
as we know them, instead sending over the specific information we need on the backend in a structured manner.This fully standardizes on the
Node
terminology. ANode
is a pointer to some content, either on the request or response side. Within this API now, we have:FileNode
: A pointer to file content.CreateCommitRequest.ModuleNode
- A set ofFileNodes
and an associatedModuleRef
that represents the content of a singleModule.
.CreateCommitRequest.DepNode
- A set of pointers to dependencies, which are just thecommit_ids
of the dependencies and their associatedDigest
(for verification).CreateCommitResponse.CommitNode
- A set of pointers to files and then actual commit dependencies.This renames
GetFileNodes
toGetCommitNodes
.To be honest, I don't love the
Node
naming, and I think it could use some work, but that's less important for the purpose of this PR. We can work on that. Ideas I've had:Info
for new nested types, ieModuleInfo, DepInfo, CommitInfo
.Data
for new nested types. In general, I think it's an anti-pattern to name a Protobuf message.*Data
, as all Protobuf messages are data, and it doesn't pluralize well.Open to other suggestions.