Allow setting spdx_license_id in module upload #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
perezd
reviewed
Oct 25, 2024
buf/registry/module/v1/commit.proto
Outdated
| // May be empty if the SPDX License Identifier was not explicitly set during upload, if the | ||
| // license file was not present, or if it was not possible to detect the SPDX License Identifier | ||
| // from the license file. | ||
| string spdx_license_id = 8; |
There was a problem hiding this comment.
should we validate these strings w/ regex?
There was a problem hiding this comment.
I think so. I went through the IDs and concluded they only contain characters a-z, A-Z, 0-9, dashes, periods, plusses. I added bufbuild/spdx-go#2 to verify this whenever we update the list. This should be the regex for this.
|
There's probably more of an argument to do add it now, especially since we allow this field to be explicitly set in PluginInfo. |
|
Also added to |
bufdev
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
spdx_license_idfield to moduleUploadRequest. The goal is to offer users more control over the resulting spdx license identifier that gets exposed once a module has been published. Such as in Generated SDKs.The intention is to add a
--spdx-license-idflag (or--licenseif we wanted to keep it short) to thebuf pushcommand.For this to be useful, we need to expand the spdx expression logic to support (in addition to the SPDX License List):
Reference