Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula depends on Go for building #16

Open
OrBin opened this issue Nov 11, 2022 · 1 comment
Open

Formula depends on Go for building #16

OrBin opened this issue Nov 11, 2022 · 1 comment

Comments

@OrBin
Copy link

OrBin commented Nov 11, 2022

This formula depends on Go for building.

It means that it installs go from the stable channel and leaves it there after installing buf, which is not really necessary.
It also means that it creates confusion regrading which is the "correct" Go binary, if another Go version is installed (e.g. [email protected] from brew) or Go is installed in other way (e.g. downloaded from https://go.dev/dl/).

I believe it's possible to change this formula so it just downloads the pre-built binary from https://github.com/bufbuild/buf/releases, at least for explicitly for linux and macOS (can still install Go and build from source otherwise, to avoid losing comptability for non-linux-and-macOS-OSes). I think it should also make the formula installation faster and more reliable (why build from source on every installation if we can use the officially-released pre-built binary?).

If you agree with my suggestion, I'd love to submit a PR that does that.

@rhbuf
Copy link

rhbuf commented Nov 25, 2022

Hi 👋 - while I know very little about homebrew, I've discussed this with the team and we'd be open to the change if you're happy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants