Improve docker build and bump deps #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Dockerfile to use best practices for cross compiling Go code to other architectures. Add a dependabot config to keep GitHub actions and Docker versions up to date. Update BUFSTREAM_VERSION in Makefile to match the version used in the docker-compose.yaml file. Update Go dependencies to the latest.
pkwarren
commented
Nov 12, 2024
| @@ -3,16 +3,17 @@ | |||
| # | |||
| # This allows users to try out this demo without needing to have Go installed, as well | |||
| # as makes the demo runnable within docker compose. | |||
| FROM golang:1.23-alpine3.20 AS builder | |||
| FROM --platform=$BUILDPLATFORM golang:1.23-alpine3.20 AS builder | |||
There was a problem hiding this comment.
rodaine
reviewed
Nov 12, 2024
Makefile
Outdated
| @@ -1,4 +1,4 @@ | |||
| BUFSTREAM_VERSION := 0.1.0 | |||
| BUFSTREAM_VERSION := 0.1.3 | |||
rodaine
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dockerfile to use best practices for cross compiling Go code to other architectures. Add a dependabot config to keep GitHub actions and Docker versions up to date. Update BUFSTREAM_VERSION in Makefile to match the version used in the docker-compose.yaml file. Update Go dependencies to the latest.