-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-darwin, non-linux builds are broken #362
Comments
These tags are as expected - we want the build to by only for Darwin and Linux, not for not-windows. Can you explain the issue?
|
Buf is broken on openbsd, freebsd, dragonfly with the current code. With my fix, it works just fine on these platforms. Why the restriction? |
Just not to duplicate the comment, I commented on cockroachdb/cockroach#67216 (comment) with what amounts to the response to this |
All the Unix systems supported by Go are compatible with the code already in buf. There's absolutely no variation in these particular features. |
The code has 4 instances of
// +build darwin linux
which should be!windows
instead.Needed for cockroachdb/cockroach#67216.
The text was updated successfully, but these errors were encountered: