Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-darwin, non-linux builds are broken #362

Closed
knz opened this issue Jul 5, 2021 · 5 comments · Fixed by #365
Closed

Non-darwin, non-linux builds are broken #362

knz opened this issue Jul 5, 2021 · 5 comments · Fixed by #365

Comments

@knz
Copy link

knz commented Jul 5, 2021

The code has 4 instances of // +build darwin linux which should be !windows instead.

Needed for cockroachdb/cockroach#67216.

@bufdev
Copy link
Member

bufdev commented Jul 5, 2021 via email

@knz
Copy link
Author

knz commented Jul 5, 2021

Buf is broken on openbsd, freebsd, dragonfly with the current code. With my fix, it works just fine on these platforms. Why the restriction?

@bufdev
Copy link
Member

bufdev commented Jul 5, 2021

Just not to duplicate the comment, I commented on cockroachdb/cockroach#67216 (comment) with what amounts to the response to this

@knz
Copy link
Author

knz commented Jul 5, 2021

All the Unix systems supported by Go are compatible with the code already in buf. There's absolutely no variation in these particular features.

@bufdev
Copy link
Member

bufdev commented Jul 5, 2021

Fixed on master in #364 and #365, this will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants