Update protovalidate-go to v0.8.0 #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thank you for doing this! I've been keeping an eye out on protovalidate-go and had this update queued, so this is very helpful!
My original thought was to first do a direct replacement as you've done here, and then consider a refactor after. I think there has been a lot of changes, mostly for the better in terms of ergonomics, since the inception of the lint rule, so there's likely a lot of improvements we could make. I'm going to stamp this first, and I think it's good to merge, and I'll bring this up in our sync today in terms of how we'd like to invest in it :)
|
SGTM. Going to go for merge, then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a breaking change in protovalidate-go v0.8.0, nothing major. Also updates protoyaml-go to v0.3.0 for the same reason.
Looks like the structured field path API might make it possible to improve this code. That said, it looks pretty carefully constructed, so I chose to do a 1:1 update instead. "First, do no harm."
I'll leave it to the reviewers to decide if I should be more aggressive about trying to refactor the code instead.