Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add period chat counts to chart legend (#323) #336

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Add period chat counts to chart legend (#323) #336

merged 8 commits into from
Oct 25, 2024

Conversation

IgorKrupenja
Copy link
Collaborator

@IgorKrupenja IgorKrupenja commented Oct 24, 2024 •
edited
Loading

Related tasks:

Notes:

  • Was not really sure about this but implemented in FE — and not SQL — since we already seem to do some calculations/data processing in FE, like getTicks here.
  • This adds chat counts to every chart legend in the module, not only those on chat page. We had a call with @RiinaLi who confirmed that this is even better — and this is actually easier to do in code.
  • Could probably have better types than Record in this PR but since we have lots of any types, refactoring this is huge and dangerous at this point.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

1AhmedYasser
1AhmedYasser approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorKrupenja IgorKrupenja marked this pull request as ready for review October 24, 2024 16:53
This was linked to issues Oct 25, 2024
In the analytics graph, update the graph legend average number of messages per conversation added in the brackets #330
Open
In the analytics graph, update the graph legend with average waiting time in minutes added in the brackets #328
Open
In the analytics graph, update the graph legend number of conversations completed by Bürokratt added in the brackets #329
Open
@rasmusei rasmusei merged commit a7d6258 into buerokratt:v2.0.2 Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1AhmedYasser 1AhmedYasser 1AhmedYasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@IgorKrupenja @1AhmedYasser @rasmusei