Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GraphQL error messages #48

Closed
delucca opened this issue Jan 14, 2021 · 1 comment
Closed

Improve GraphQL error messages #48

delucca opened this issue Jan 14, 2021 · 1 comment
Labels
tech debt A suboptimal working feature that requires future improvements

Comments

@delucca
Copy link

delucca commented Jan 14, 2021

💩 How it is currently developed

Our GraphQL errors have not customization while returning to the request. They're like NestJS returns it.

🌟 What is the optimal solution

We should improve the format of GraphQL errors. We could follow this suggestion: nestjs/graphql#1053 (comment)

😓 Why we did that way

To move fast.

💣 What are the possible impacts

We can lose time debugging because our error is not formatted accordingly.
@delucca delucca added the tech debt A suboptimal working feature that requires future improvements label Jan 14, 2021
@delucca
Copy link
Author

delucca commented Mar 17, 2021

Closed since we're now using ApolloErrors.

@delucca delucca closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt A suboptimal working feature that requires future improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delucca