extended matches shouldn't be displayed as the main title of the work matches

[eroux]

For instance in https://library.bdrc.io/search?q=%22performance%22&lg=en&t=Work i've just added the extended matches, and most of them are in the catalogInfo field but they appear as the main label

[eroux]

oh, note that the same bug appears on the Versions results too

[berger-n]

I've added catalogInfo to results for Work so as this becomes that:

but are sure what you're reporting is a bug?
to me these are matching altLabels, at least regarding these four leading results having a match in their main title:

there also seems to have duplicate catalogInfo in query for versions:

resulting in duplicate display:

(but I guess I'll have to handle these client-side)

[eroux]

Ah thanks! I'll have a look at the duplicates in catalogInfo tomorrow. Matches in altLabels are interesting... Do we have another place to display them? maybe a Other title? The ideal would be to always display the prefLabel as the main label for the item (not the altLabel, even when there's a match)... would that be complex to implement?

[eroux]

Ah, well, actually the duplicate catalogInfo (one with highlight, one without) should be handled on the client indeed, like the prefLabel

[eroux]

actually never mind: buda-base/xmltoldmigration#156

[eroux]

duplicates have disappeared! also, related: buda-base/lds-queries#61

[berger-n]

well done, thanks!
I've noticed that highlighting has disappeared in matching note here: https://library.bdrc.io/search?q=%22rituals%20for%20the%20performance%22&lg=en&t=Instance&f=asset,inc,tmp:hasOpen
I can put in back using case insensitive search for keyword but it will use keyword instead of original string in highlighted property value (capital letters might disappear), is that ok?

[eroux]

hmmm... it's more or less intended as it's a field that comes from the work and the search actually doesn't search on this field (it's a coincidence that there's a match here)... so, maybe let's not do that, at least not now

[berger-n]

nevermind I managed to keep the original string:

this is the default behaviour to look for keyword and highlight it when found
do you want to disable it in this "catalogInfo of version" special case?

[eroux]

ah no never mind, if it's already in place let's keep it!

[berger-n]

altLabels are not used in result title anymore: https://library.bdrc.io/search?q=%22for%20the%20performance%22&lg=en&t=Work

[eroux]

great, thanks a lot!

[berger-n]

just fixed missing highlighting here: http://library-dev.bdrc.io/search?q=%22Mar%20me%20smon%20lam%22~1&lg=bo-x-ewts&t=Instance

not using matching altLabel as result title as expected here: http://library-dev.bdrc.io/search?q=%22for%20the%20performance%22&lg=en&t=Work