txscript/engine: add execution StepCallback #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5785035301
💛 - Coveralls |
Roasbeef
reviewed
May 10, 2023
|
Rebased and addressed comments. PTAL @Roasbeef @kcalvinalvin |
|
Rebased. PTAL @Roasbeef |
Roasbeef
requested changes
Jun 29, 2023
halseth
force-pushed
the
script-callback
branch
from
363479f
to
552cb80
Compare
We add a new stepCallback as optional function closure on the Engine that will be called every time a step has been performed during script execution. It is accessed by calling the NewDebugEngine constructor. This is only meant to be used in debugging.
Add a simple test that make sure the stack and alt stack is correctly set in the callback from script execution.
halseth
force-pushed
the
script-callback
branch
from
552cb80
to
5c5bef0
Compare
|
Rabased. |
Roasbeef
approved these changes
Aug 15, 2023
|
|
||
| // TestDebugEngine checks that the StepCallbck called during debug script | ||
| // execution contains the expected data. | ||
| func TestDebugEngine(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new StepCallback as optional function closure on the Engine that will be called every time a step has been performed during script execution.
This is only meant to be used in debugging.
More specifically, this is used for Tapsim: https://github.com/halseth/tapsim