build: multiple cleanups #1575
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Build and Test | ||
| on: [push, pull_request] | ||
| jobs: | ||
| build: | ||
| name: Go CI | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| go: [1.13, 1.14] | ||
| steps: | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: ${{ matrix.go }} | ||
| - name: Check out source | ||
| uses: actions/checkout@v2 | ||
| - name: Install Linters | ||
| run: "curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.26.0" | ||
| - name: Build | ||
| env: | ||
| GO111MODULE: "on" | ||
| run: go build ./... | ||
| - name: Test | ||
| env: | ||
| GO111MODULE: "on" | ||
| run: | | ||
| sh ./goclean.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -287,6 +287,6 @@ func RegisteredCmdMethods() []string { | |
| methods = append(methods, k) | ||
| } | ||
|
|
||
| sort.Strings(methods) | ||
| return methods | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,16 @@ | ||
| module github.com/btcsuite/btcd | ||
|
|
||
| require ( | ||
| github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f | ||
| github.com/btcsuite/btcutil v1.0.2 | ||
| github.com/btcsuite/go-socks v0.0.0-20170105172521-4720035b7bfd | ||
| github.com/btcsuite/goleveldb v1.0.0 | ||
|
There was a problem hiding this comment. Given modules exist now, do we still need to vendor There was a problem hiding this comment. Our fork looks to be a year or so behind mainline: https://github.com/syndtr/goleveldb |
||
| github.com/btcsuite/websocket v0.0.0-20150119174127-31079b680792 | ||
| github.com/btcsuite/winsvc v1.0.0 | ||
| github.com/davecgh/go-spew v1.1.1 | ||
| github.com/jessevdk/go-flags v1.4.0 | ||
| github.com/jrick/logrotate v1.0.0 | ||
| golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37 | ||
| ) | ||
|
|
||
| go 1.12 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,18 @@ | ||
| #!/bin/bash | ||
| # The script does automatic checking on a Go package and its sub-packages, including: | ||
| # 1. gofmt (http://golang.org/cmd/gofmt/) | ||
| # 3. go vet (http://golang.org/cmd/vet) | ||
| # 4. gosimple (https://github.com/dominikh/go-simple) | ||
| # 5. unconvert (https://github.com/mdempsky/unconvert) | ||
| # | ||
|
|
||
| set -ex | ||
|
|
||
| go test -tags="rpctest" ./... | ||
|
|
||
| # Automatic checks | ||
| golangci-lint run --deadline=10m --disable-all \ | ||
| --enable=gofmt \ | ||
| --enable=vet \ | ||
| --enable=gosimple \ | ||
| --enable=unconvert |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I think this had been around since the struct was introduced.